krishan1390 commented on code in PR #17443:
URL: https://github.com/apache/pinot/pull/17443#discussion_r2664856541
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/PinotSegmentColumnarDataSource.java:
##########
@@ -47,13 +52,18 @@ public int getTotalDocs() {
@Override
public ColumnReaderFactory createColumnReaderFactory() {
- return new PinotSegmentColumnReaderFactory(_indexSegment,
_initializeDefaultValueReaders);
+ return new PinotSegmentColumnReaderFactory(_indexSegment, true, false);
+ }
+
+ @Override
+ public RoaringBitmap getValidDocIds() {
+ return _validDocIds;
}
@Override
public void close()
throws IOException {
- // Segment lifecycle is managed externally, so no cleanup needed here
+ _indexSegment.destroy();
Review Comment:
Pinot segment record reader also destroys the segment by default, thus
enabling the same capability here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
