anuragrai16 commented on code in PR #17081:
URL: https://github.com/apache/pinot/pull/17081#discussion_r2471773846
##########
pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/TimeSeriesRequestHandlerTest.java:
##########
@@ -0,0 +1,151 @@
+package org.apache.pinot.broker.requesthandler;
+
+import java.util.List;
+import org.apache.pinot.spi.data.Schema;
+import org.apache.pinot.spi.exception.QueryErrorCode;
+import org.apache.pinot.spi.exception.QueryException;
+import org.apache.pinot.tsdb.spi.plan.LeafTimeSeriesPlanNode;
+import org.mockito.Mock;
+import org.mockito.MockitoAnnotations;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+import static org.mockito.Mockito.lenient;
+import static org.mockito.Mockito.when;
+import static org.testng.Assert.*;
+
+
+public class TimeSeriesRequestHandlerTest {
+
+ private AutoCloseable _mocks;
+
+ @Mock
+ private LeafTimeSeriesPlanNode _leafNode;
+ @Mock
+ private Schema _tableSchema;
+
+ @BeforeMethod
+ public void setUp() {
+ _mocks = MockitoAnnotations.openMocks(this);
+
+ // Set up default mock behaviors
+ lenient().when(_leafNode.getTableName()).thenReturn("metrics_REALTIME");
+ lenient().when(_tableSchema.hasColumn("ts")).thenReturn(true);
+ lenient().when(_tableSchema.hasColumn("colA")).thenReturn(true);
+ lenient().when(_tableSchema.hasColumn("colB")).thenReturn(true);
+ lenient().when(_tableSchema.hasColumn("colC")).thenReturn(true);
+ }
+
+ @Test
+ void testValidateColumnNamesSuccess() {
+ when(_leafNode.getTimeColumn()).thenReturn("ts");
+ when(_leafNode.getValueExpression()).thenReturn("SUM(colA)");
+ when(_leafNode.getGroupByExpressions()).thenReturn(List.of("colB",
"DIMENSION(colC)"));
+ when(_leafNode.getFilterExpression()).thenReturn("colB > 10 AND colA < 5
AND ts > 12345");
+
+ try {
+ TimeSeriesRequestHandler.validateColumnNames(_leafNode, _tableSchema);
+ } catch (Exception e) {
+ fail("Should not throw exception when all columns are valid: " +
e.getMessage());
+ }
+ }
+
+ @Test
+ public void testValidateColumnNamesWhenInvalidTimeColumn() {
+ when(_leafNode.getTimeColumn()).thenReturn("invalid_ts_column");
+ when(_tableSchema.hasColumn("invalid_ts_column")).thenReturn(false);
+
+ try {
+ TimeSeriesRequestHandler.validateColumnNames(_leafNode, _tableSchema);
+ fail("Expected a QueryException to be thrown");
+ } catch (QueryException e) {
+ assertEquals(e.getErrorCode(), QueryErrorCode.UNKNOWN_COLUMN);
+ assertTrue(e.getMessage().contains("Time column 'invalid_ts_column' not
found"));
+ } catch (Exception e) {
+ fail("Expected QueryException, but got " + e.getClass().getName(), e);
+ }
+ }
+
+ @Test
+ public void testValidateColumnNamesWhenInvalidValueExpressionColumn() {
+ when(_leafNode.getTimeColumn()).thenReturn("ts");
Review Comment:
Added "testValidateColumnNamesSuccessWithTimeColumnExpression"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
