ankitsultana commented on code in PR #17081:
URL: https://github.com/apache/pinot/pull/17081#discussion_r2470892243
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/TimeSeriesRequestHandler.java:
##########
@@ -238,6 +249,85 @@ private void
firstStageAccessControlCheck(RequesterIdentity requesterIdentity) {
}
}
+ private void validatePhysicalPlan(HttpHeaders httpHeaders,
TimeSeriesDispatchablePlan dispatchablePlan) {
+ // check authorization for table
+ tableLevelAccessControlCheck(httpHeaders,
dispatchablePlan.getTableNames());
+ // validate column names for all LeafTimeSeriesPlanNode in the physical
plan
Review Comment:
let's move this to a separate method and call that method here? We can
continue adding other validations here following that pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
