ankitsultana commented on code in PR #17081:
URL: https://github.com/apache/pinot/pull/17081#discussion_r2467172195
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/TimeSeriesRequestHandler.java:
##########
@@ -132,16 +142,18 @@ public TimeSeriesBlock handleTimeSeriesRequest(String
lang, String rawQueryParam
}
TimeSeriesDispatchablePlan dispatchablePlan =
_queryEnvironment.buildPhysicalPlan(timeSeriesRequest,
requestContext, logicalPlanResult);
+ validatePhysicalPlan(httpHeaders, dispatchablePlan);
- tableLevelAccessControlCheck(httpHeaders,
dispatchablePlan.getTableNames());
timeSeriesBlock =
_queryDispatcher.submitAndGet(requestContext.getRequestId(), dispatchablePlan,
timeSeriesRequest.getTimeout().toMillis(), requestContext);
return timeSeriesBlock;
} catch (Exception e) {
_brokerMetrics.addMeteredGlobalValue(BrokerMeter.TIME_SERIES_GLOBAL_QUERIES_FAILED,
1);
if (e instanceof QueryException) {
throw (QueryException) e;
- } else {
+ } else if (e instanceof IllegalArgumentException) {
Review Comment:
Can you return QueryException here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
