anuragrai16 commented on code in PR #17081:
URL: https://github.com/apache/pinot/pull/17081#discussion_r2466294369
##########
pinot-plugins/pinot-timeseries-lang/pinot-timeseries-m3ql/src/main/java/org/apache/pinot/tsdb/m3ql/M3TimeSeriesPlanner.java:
##########
@@ -55,13 +63,13 @@ public TimeSeriesLogicalPlanResult
plan(RangeTimeSeriesRequest request, TimeSeri
String.format("Invalid engine id: %s. Expected: %s",
request.getLanguage(), Constants.LANGUAGE));
}
// Step-1: Parse and create a logical plan tree.
- BaseTimeSeriesPlanNode planNode = planQuery(request);
+ BaseTimeSeriesPlanNode planNode = planQuery(request, metadata);
// Step-2: Compute the time-buckets.
TimeBuckets timeBuckets = TimeBucketComputer.compute(planNode, request);
return new TimeSeriesLogicalPlanResult(planNode, timeBuckets);
}
- public BaseTimeSeriesPlanNode planQuery(RangeTimeSeriesRequest request) {
+ public BaseTimeSeriesPlanNode planQuery(RangeTimeSeriesRequest request,
TimeSeriesMetadata metadata) {
Review Comment:
Makes sense, yeah. Let me add it in the `TimeSeriesRequestHandler`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
