Jackie-Jiang commented on code in PR #16728:
URL: https://github.com/apache/pinot/pull/16728#discussion_r2350132629
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -452,11 +451,9 @@ public String cancelQuery(
@DefaultValue("3000") int timeoutMs,
@ApiParam(value = "Return server responses for troubleshooting")
@QueryParam("verbose") @DefaultValue("false")
boolean verbose) {
- try (QueryThreadContext.CloseableContext closeMe =
QueryThreadContext.open(_instanceId)) {
+ try {
Map<String, Integer> serverResponses = verbose ? new HashMap<>() : null;
if (isClient) {
- long reqId = _requestHandler.getRequestIdByClientId(id).orElse(-1L);
- QueryThreadContext.setIds(reqId, id);
Review Comment:
I don't follow why we need this to be thread local. It should be shared
across all threads for a given query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
