Jackie-Jiang commented on code in PR #16728:
URL: https://github.com/apache/pinot/pull/16728#discussion_r2350092255
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/BaseOperator.java:
##########
@@ -59,6 +53,18 @@ public ExplainInfo getExplainInfo() {
return new ExplainInfo(getExplainName(), attributeBuilder.build(),
getChildrenExplainInfo());
}
+ protected void checkTermination() {
+ QueryThreadContext.checkTermination(this::getExplainName);
+ }
+
+ protected void checkTerminationAndSampleUsage() {
+ QueryThreadContext.checkTerminationAndSampleUsage(this::getExplainName);
+ }
+
+ protected void checkTerminationAndSampleUsagePeriodically(int
numRecordsProcessed) {
+
QueryThreadContext.checkTerminationAndSampleUsagePeriodically(numRecordsProcessed,
this::getExplainName);
+ }
Review Comment:
Do you mean overriding this method on a per operator basis? That would be a
lot of changes, and I don't know if the overloading could cause other overhead.
We should probably benchmark and see if it is an overhead (hopefully JIT can do
its job)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
