Jackie-Jiang commented on code in PR #16728:
URL: https://github.com/apache/pinot/pull/16728#discussion_r2360751062
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -379,43 +379,32 @@ private void checkAuthorization(RequesterIdentity
requesterIdentity, RequestCont
private ImmutableQueryEnvironment.Config getQueryEnvConf(HttpHeaders
httpHeaders, Map<String, String> queryOptions,
long requestId) {
String database =
DatabaseUtils.extractDatabaseFromQueryRequest(queryOptions, httpHeaders);
- boolean inferPartitionHint =
_config.getProperty(CommonConstants.Broker.CONFIG_OF_INFER_PARTITION_HINT,
- CommonConstants.Broker.DEFAULT_INFER_PARTITION_HINT);
- boolean defaultUseSpool =
_config.getProperty(CommonConstants.Broker.CONFIG_OF_SPOOLS,
- CommonConstants.Broker.DEFAULT_OF_SPOOLS);
- boolean defaultUseLeafServerForIntermediateStage = _config.getProperty(
-
CommonConstants.Broker.CONFIG_OF_USE_LEAF_SERVER_FOR_INTERMEDIATE_STAGE,
- CommonConstants.Broker.DEFAULT_USE_LEAF_SERVER_FOR_INTERMEDIATE_STAGE);
- boolean defaultEnableGroupTrim =
_config.getProperty(CommonConstants.Broker.CONFIG_OF_MSE_ENABLE_GROUP_TRIM,
- CommonConstants.Broker.DEFAULT_MSE_ENABLE_GROUP_TRIM);
- boolean defaultEnableDynamicFilteringSemiJoin = _config.getProperty(
-
CommonConstants.Broker.CONFIG_OF_BROKER_ENABLE_DYNAMIC_FILTERING_SEMI_JOIN,
- CommonConstants.Broker.DEFAULT_ENABLE_DYNAMIC_FILTERING_SEMI_JOIN);
- boolean defaultUsePhysicalOptimizer = _config.getProperty(
- CommonConstants.Broker.CONFIG_OF_USE_PHYSICAL_OPTIMIZER,
- CommonConstants.Broker.DEFAULT_USE_PHYSICAL_OPTIMIZER);
- boolean defaultUseLiteMode = _config.getProperty(
- CommonConstants.Broker.CONFIG_OF_USE_LITE_MODE,
- CommonConstants.Broker.DEFAULT_USE_LITE_MODE);
- boolean defaultRunInBroker = _config.getProperty(
- CommonConstants.Broker.CONFIG_OF_RUN_IN_BROKER,
- CommonConstants.Broker.DEFAULT_RUN_IN_BROKER);
- boolean defaultUseBrokerPruning = _config.getProperty(
- CommonConstants.Broker.CONFIG_OF_USE_BROKER_PRUNING,
- CommonConstants.Broker.DEFAULT_USE_BROKER_PRUNING);
- int defaultLiteModeLeafStageLimit = _config.getProperty(
- CommonConstants.Broker.CONFIG_OF_LITE_MODE_LEAF_STAGE_LIMIT,
- CommonConstants.Broker.DEFAULT_LITE_MODE_LEAF_STAGE_LIMIT);
- int defaultLiteModeFanoutAdjustedLimit = _config.getProperty(
-
CommonConstants.Broker.CONFIG_OF_LITE_MODE_LEAF_STAGE_FANOUT_ADJUSTED_LIMIT,
-
CommonConstants.Broker.DEFAULT_LITE_MODE_LEAF_STAGE_FAN_OUT_ADJUSTED_LIMIT);
- String defaultHashFunction = _config.getProperty(
- CommonConstants.Broker.CONFIG_OF_BROKER_DEFAULT_HASH_FUNCTION,
- CommonConstants.Broker.DEFAULT_BROKER_DEFAULT_HASH_FUNCTION);
- boolean caseSensitive = !_config.getProperty(
- CommonConstants.Helix.ENABLE_CASE_INSENSITIVE_KEY,
- CommonConstants.Helix.DEFAULT_ENABLE_CASE_INSENSITIVE
- );
+ boolean inferPartitionHint =
+ _config.getProperty(Broker.CONFIG_OF_INFER_PARTITION_HINT,
Broker.DEFAULT_INFER_PARTITION_HINT);
+ boolean defaultUseSpool = _config.getProperty(Broker.CONFIG_OF_SPOOLS,
Broker.DEFAULT_OF_SPOOLS);
+ boolean defaultUseLeafServerForIntermediateStage =
+
_config.getProperty(Broker.CONFIG_OF_USE_LEAF_SERVER_FOR_INTERMEDIATE_STAGE,
+ Broker.DEFAULT_USE_LEAF_SERVER_FOR_INTERMEDIATE_STAGE);
+ boolean defaultEnableGroupTrim =
+ _config.getProperty(Broker.CONFIG_OF_MSE_ENABLE_GROUP_TRIM,
Broker.DEFAULT_MSE_ENABLE_GROUP_TRIM);
+ boolean defaultEnableDynamicFilteringSemiJoin =
+
_config.getProperty(Broker.CONFIG_OF_BROKER_ENABLE_DYNAMIC_FILTERING_SEMI_JOIN,
+ Broker.DEFAULT_ENABLE_DYNAMIC_FILTERING_SEMI_JOIN);
+ boolean defaultUsePhysicalOptimizer =
+ _config.getProperty(Broker.CONFIG_OF_USE_PHYSICAL_OPTIMIZER,
Broker.DEFAULT_USE_PHYSICAL_OPTIMIZER);
+ boolean defaultUseLiteMode =
_config.getProperty(Broker.CONFIG_OF_USE_LITE_MODE,
Broker.DEFAULT_USE_LITE_MODE);
+ boolean defaultRunInBroker =
_config.getProperty(Broker.CONFIG_OF_RUN_IN_BROKER,
Broker.DEFAULT_RUN_IN_BROKER);
+ boolean defaultUseBrokerPruning =
+ _config.getProperty(Broker.CONFIG_OF_USE_BROKER_PRUNING,
Broker.DEFAULT_USE_BROKER_PRUNING);
+ int defaultLiteModeLeafStageLimit =
+ _config.getProperty(Broker.CONFIG_OF_LITE_MODE_LEAF_STAGE_LIMIT,
Broker.DEFAULT_LITE_MODE_LEAF_STAGE_LIMIT);
+ int defaultLiteModeFanoutAdjustedLimit =
+
_config.getProperty(Broker.CONFIG_OF_LITE_MODE_LEAF_STAGE_FANOUT_ADJUSTED_LIMIT,
+ Broker.DEFAULT_LITE_MODE_LEAF_STAGE_FAN_OUT_ADJUSTED_LIMIT);
+ String defaultHashFunction =
+ _config.getProperty(Broker.CONFIG_OF_BROKER_DEFAULT_HASH_FUNCTION,
Broker.DEFAULT_BROKER_DEFAULT_HASH_FUNCTION);
+ boolean caseSensitive =
+ !_config.getProperty(Helix.ENABLE_CASE_INSENSITIVE_KEY,
Helix.DEFAULT_ENABLE_CASE_INSENSITIVE);
Review Comment:
Let me revert this and do it in a separate PR if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
