gortiz commented on code in PR #16728:
URL: https://github.com/apache/pinot/pull/16728#discussion_r2361905257


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -458,15 +447,14 @@ private BrokerResponse 
explain(QueryEnvironment.CompiledQuery query, long reques
       throws WebApplicationException, QueryException {
     Map<String, String> queryOptions = query.getOptions();
 
-    boolean askServers = QueryOptionsUtils.isExplainAskingServers(queryOptions)
-        .orElse(_explainAskingServerDefault);
+    boolean askServers = 
QueryOptionsUtils.isExplainAskingServers(queryOptions).orElse(_explainAskingServerDefault);
     @Nullable
-    AskingServerStageExplainer.OnServerExplainer fragmentToPlanNode = 
askServers
-        ? fragment -> requestPhysicalPlan(fragment, requestContext, 
timer.getRemainingTimeMs(), queryOptions)
-        : null;
+    AskingServerStageExplainer.OnServerExplainer fragmentToPlanNode =
+        askServers ? fragment -> requestPhysicalPlan(fragment, requestContext, 
timer.getRemainingTimeMs(), queryOptions)

Review Comment:
   Most of these changes are not against our standard format, which is quite 
relaxed in terms of line breaks and other details. We should remove these 
auto-rules from our IDEs; otherwise, we will encounter this kind of PR 
frequently when two different IDEs apply different changes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to