swaminathanmanish commented on code in PR #16571:
URL: https://github.com/apache/pinot/pull/16571#discussion_r2270356582
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##########
@@ -238,6 +238,15 @@ public Map<String, String> createTask(String taskType,
String tableName, @Nullab
LOGGER.warn("No ad-hoc task generated for task type: {}", taskType);
continue;
}
+ int maxNumberOfSubTasks = taskGenerator.getMaxNumSubTasks();
Review Comment:
We are defining the behavior here so I think its better to align on the
behavior because it will take effect once we update the cluster config to a
smaller value.
My concern is that this will silently result in partial ingestion and the
user is not aware. Is that OK?
cc @xiangfu0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
