krishan1390 commented on code in PR #16571:
URL: https://github.com/apache/pinot/pull/16571#discussion_r2269431191
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##########
@@ -238,6 +238,15 @@ public Map<String, String> createTask(String taskType,
String tableName, @Nullab
LOGGER.warn("No ad-hoc task generated for task type: {}", taskType);
continue;
}
+ int maxNumberOfSubTasks = taskGenerator.getMaxNumSubTasks();
Review Comment:
My opinion is we should not fail unless we really need to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
