shounakmk219 commented on code in PR #16571:
URL: https://github.com/apache/pinot/pull/16571#discussion_r2272306294
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/TaskSchedulingContext.java:
##########
@@ -132,4 +133,9 @@ public TaskSchedulingContext setLeader(boolean leader) {
_isLeader = leader;
return this;
}
+
+ public static boolean isUserTriggeredTask(String triggeredBy) {
+ return
CommonConstants.TaskTriggers.MANUAL_TRIGGER.toString().equals(triggeredBy)
Review Comment:
`MANUAL_TRIGGER` sticks to the task configs provided as part of table,
should we treat it in same way as `ADHOC_TRIGGER`? We don't want to end up in a
place where "-1" fails in schedule but as soon as user clicks "Schedule Now" it
goes through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
