krishan1390 commented on code in PR #16571:
URL: https://github.com/apache/pinot/pull/16571#discussion_r2272345190
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/TaskSchedulingContext.java:
##########
@@ -132,4 +133,9 @@ public TaskSchedulingContext setLeader(boolean leader) {
_isLeader = leader;
return this;
}
+
+ public static boolean isUserTriggeredTask(String triggeredBy) {
+ return
CommonConstants.TaskTriggers.MANUAL_TRIGGER.toString().equals(triggeredBy)
Review Comment:
yea because programattic calling /tasks/schedule API should fail because we
dont want partial task to run and want user to know task configs need to be
updated
>We don't want to end up in a place where "-1" fails in schedule but as soon
as user clicks "Schedule Now" it goes through.
This won't happen. the "schedule now" click will fail. but the cron schedule
will pass with truncated sub tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
