Jackie-Jiang commented on PR #16254: URL: https://github.com/apache/pinot/pull/16254#issuecomment-3054185925
@jadami10 Removing special keys from `GenericRow` requires changing the interface of `RecordTransformer`, thus all implementations of `RecordTransformer`s need to be adjusted accordingly. Can you share how do you use `$MULTIPLE_RECORDS_KEY$` and `$SKIP_RECORD_KEY$`? With this change, `$MULTIPLE_RECORDS_KEY$` is replaced with a list of regular `GenericRow`, `$SKIP_RECORD_KEY$` is replaced with empty list. This way the handling is much more intuitive and less error prone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
