Jackie-Jiang commented on code in PR #16254:
URL: https://github.com/apache/pinot/pull/16254#discussion_r2193575069
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/readers/GenericRow.java:
##########
@@ -100,7 +80,7 @@ public void init(GenericRow row) {
* the value for the field can be {@code null}.
*/
public Map<String, Object> getFieldToValueMap() {
- return Collections.unmodifiableMap(_fieldToValueMap);
+ return _fieldToValueMap;
Review Comment:
Allow directly modifying the map for better performance (reduce key lookups)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
