Jackie-Jiang commented on code in PR #16254:
URL: https://github.com/apache/pinot/pull/16254#discussion_r2193572982
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/FilterTransformer.java:
##########
@@ -56,16 +61,20 @@ public boolean isNoOp() {
@Override
public List<String> getInputColumns() {
- return _evaluator != null ? _evaluator.getArguments() : List.of();
+ assert _evaluator != null;
+ return _evaluator.getArguments();
}
@Override
- public GenericRow transform(GenericRow record) {
- if (_evaluator != null) {
+ public List<GenericRow> transform(List<GenericRow> records) {
+ assert _evaluator != null;
Review Comment:
This transformer won't be registered when it is no-op
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
