vvivekiyer commented on code in PR #15798:
URL: https://github.com/apache/pinot/pull/15798#discussion_r2190738561
##########
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##########
@@ -276,7 +282,17 @@ public void
setThreadResourceUsageProvider(ThreadResourceUsageProvider threadRes
}
@Override
+ @Deprecated
public void updateQueryUsageConcurrently(String queryId, long cpuTimeNs,
long memoryAllocatedBytes) {
+ }
+
+ @Override
+ public void updateQueryUsageConcurrently(String queryId, long cpuTimeNs,
long memoryAllocatedBytes,
+ TrackingScope trackingScope) {
+ if (trackingScope != TrackingScope.QUERY) {
Review Comment:
Yeah, the switch will involve Q&A effort. So, we'll be doing the Q&A and
enabling it in all of our production. We'll deprecate the
`PerQueryCPUMem..Acountant` only after there is sufficient confidence that it
works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
