vvivekiyer commented on code in PR #15798:
URL: https://github.com/apache/pinot/pull/15798#discussion_r2114790028


##########
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##########
@@ -262,7 +268,11 @@ public int getEntryCount() {
     }
 
     @Override
-    public void updateQueryUsageConcurrently(String queryId) {
+    public void updateResourceUsageConcurrently(String queryId, TrackingScope 
resourceType) {
+      if (!resourceType.equals(TrackingScope.QUERY)) {

Review Comment:
   We can't assert here. This function is called for all scopes. It's a no-op 
if the associated scope is not enabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to