praveenc7 commented on code in PR #15798:
URL: https://github.com/apache/pinot/pull/15798#discussion_r2162718304
##########
pinot-spi/src/main/java/org/apache/pinot/spi/trace/Tracing.java:
##########
@@ -350,8 +362,8 @@ public static void sampleAndCheckInterruption() {
sample();
}
- public static void updateQueryUsageConcurrently(String queryId) {
- Tracing.getThreadAccountant().updateQueryUsageConcurrently(queryId);
+ public static void updateResourceUsageConcurrently(String resourceName,
TrackingScope trackingScope) {
Review Comment:
Our goal is to migrate `PerQueryCpuMemAccountant` into
`ResourceManagementAccountant`, then retire the former entirely. During the
transition we’ll keep both in place so nothing breaks.
`TrackingScope` lets each sample tell the system which aggregator should
record its resource usage. Other way is to have `if (accountant instanceof …)`
branching; the scope tag routes the data to the right place without extra
runtime checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
