gortiz commented on PR #15798: URL: https://github.com/apache/pinot/pull/15798#issuecomment-3019779558
> Created a generic accountant called ResourceUsageAccountant that can support both query based accounting and Workload based accounting. It contains all function of the existing account (PerQueryCPUMemAccountantFactory) in addition to workload support. The reason for creating a generic accountant is to make sure Thread&Task state is managed in one place. Why do you need that? Couldn't apply a decorate pattern where PerQueryCPUMemAccountantFactory keeps the logic per query and then a WorkloadAccountant groups the per query map into a per workload map? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
