tarun11Mavani commented on code in PR #16086:
URL: https://github.com/apache/pinot/pull/16086#discussion_r2152063569
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGenerator.java:
##########
@@ -462,4 +464,10 @@ protected String
getSegmentCrcList(List<SegmentMergerMetadata> segmentMergerMeta
segmentMergerMetadataList.stream().map(x ->
String.valueOf(x.getSegmentZKMetadata().getCrc()))
.collect(Collectors.toList()), ",");
}
+
+ @VisibleForTesting
+ protected long getMaxCreationTimeMillis(List<SegmentMergerMetadata>
segmentMergerMetadataList) {
Review Comment:
I wanted to keep the same behaviour as getCreationTime() which also returns
-1 if it's not present.
This is why I am returning -1 and then added a check in executor to check
for time > 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
