ankitsultana commented on code in PR #16086: URL: https://github.com/apache/pinot/pull/16086#discussion_r2150433513
########## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGeneratorTest.java: ########## @@ -238,4 +238,29 @@ public void testGetSegmentCrcList() { ); Assert.assertEquals(_taskGenerator.getSegmentCrcList(segmentMergerMetadataList), "1000,2000"); } + + @Test + public void testGetMaxCreationTimeMillis() { Review Comment: Do we have a framework to run E2E tests for Minion tasks? Ideally we should be able to use a JSON file to specify a test input and the expected output for task generators at least. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org