tarun11Mavani commented on code in PR #16086:
URL: https://github.com/apache/pinot/pull/16086#discussion_r2151477934
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/test/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskGeneratorTest.java:
##########
@@ -238,4 +238,29 @@ public void testGetSegmentCrcList() {
);
Assert.assertEquals(_taskGenerator.getSegmentCrcList(segmentMergerMetadataList),
"1000,2000");
}
+
+ @Test
+ public void testGetMaxCreationTimeMillis() {
Review Comment:
Yes, We comprehensive E2E testing frameworks for Minion tasks, though they
don't currently use JSON-based configuration files for test specification. The
framework is built around integration tests that spin up full Pinot clusters
and execute real Minion tasks.
We have IT for MergeRollupTask and RealtimeToOfflineSegmentsTask etc. I plan
to add UTs for MergeCompact task and will IT as in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
