rohityadav1993 commented on code in PR #16086:
URL: https://github.com/apache/pinot/pull/16086#discussion_r2151886382
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompactmerge/UpsertCompactMergeTaskExecutor.java:
##########
@@ -202,4 +194,36 @@ void validateCRCForInputSegments(List<SegmentMetadataImpl>
segmentMetadataList,
}
}
}
+
+ /**
+ * Retrieves the max creation time from task configuration with proper null
handling.
+ *
+ * @param configs Task configuration map
+ * @return Max creation time in milliseconds
+ * @throws IllegalStateException if the configuration value is invalid
+ */
+ long getMaxCreationTimeFromConfig(Map<String, String> configs) {
+ String maxCreationTimeStr =
configs.get(MinionConstants.UpsertCompactMergeTask.MAX_CREATION_TIME_MILLIS_KEY);
+ if (maxCreationTimeStr == null) {
+ String message = "Max creation time configuration is missing from task
config.";
+ LOGGER.warn(message);
Review Comment:
nit: logging the same message as exception message can be redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
