yashmayya commented on PR #15203: URL: https://github.com/apache/pinot/pull/15203#issuecomment-2964791938
@wirybeaver the multiple tenants / pools thing is a secondary concern. The primary concern is calling instance pools replica groups (query option, query logs, metrics), when we already have a totally separate concept of replica groups that can be used with or without instance pools (and like I pointed out above, an instance pool can itself have one or more replica groups assigned per table). > Actually, you should conceptually replace every "Group" or "Replica Group" with the "Pool" when you review the code. I can have a follow up PR to rename for easier readability, add a new query option "orderedPreferredPools" and mark the old query option with Depreciated annotation. It's not just about readability, since this is now user-facing terminology with the added query option, query logs and metrics. We can't simply use instance pools and replica groups interchangeably because they're separate, unrelated concepts. Please take a look at the instance assignment code in Pinot for more details - https://github.com/apache/pinot/tree/master/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
