wirybeaver commented on code in PR #15203:
URL: https://github.com/apache/pinot/pull/15203#discussion_r2098485731
##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BaseInstanceSelector.java:
##########
@@ -88,6 +93,7 @@ abstract class BaseInstanceSelector implements
InstanceSelector {
final ZkHelixPropertyStore<ZNRecord> _propertyStore;
final BrokerMetrics _brokerMetrics;
final AdaptiveServerSelector _adaptiveServerSelector;
+ final PriorityGroupInstanceSelector _priorityGroupInstanceSelector;
Review Comment:
I also add a comment `Will be null if and only if adaptiveServerSelector is
null` above the field PriorityGroupInstanceSelector. IMO, `@Nullable` means
that the value can be set to null independently anytime. @gortiz would it make
sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
