somandal commented on code in PR #15203:
URL: https://github.com/apache/pinot/pull/15203#discussion_r2141196007
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -758,6 +761,11 @@ protected BrokerResponse doHandleRequest(long requestId,
String query, SqlNodeAn
remainingTimeMs, serverStats, requestContext);
}
brokerResponse.setTablesQueried(Set.of(rawTableName));
+ brokerResponse.setReplicaGroups(Stream.concat(
+ offlineExecutionServers != null ? offlineExecutionServers.stream()
: Stream.empty(),
+ realtimeExecutionServers != null ?
realtimeExecutionServers.stream() : Stream.empty())
+ .map(ServerInstance::getPool)
+ .collect(Collectors.toSet()));
Review Comment:
I'm a little confused as well, how will this work if there is a single pool
but with replica groups configured? and will this just result in only being
able to set preferred as "0"? is there a design doc for this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
