ankitsultana commented on code in PR #15959: URL: https://github.com/apache/pinot/pull/15959#discussion_r2127042235
########## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/LeafStageToPinotQuery.java: ########## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.query.planner.logical; + +import com.google.common.base.Preconditions; +import java.util.ArrayList; +import java.util.List; +import java.util.stream.Collectors; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Filter; +import org.apache.calcite.rel.core.Project; +import org.apache.calcite.rel.core.TableScan; +import org.apache.pinot.common.request.DataSource; +import org.apache.pinot.common.request.Expression; +import org.apache.pinot.common.request.PinotQuery; +import org.apache.pinot.query.parser.CalciteRexExpressionParser; +import org.apache.pinot.sql.parsers.CalciteSqlParser; + + +/** + * Utility to convert a leaf stage to a {@link PinotQuery}. + */ +public class LeafStageToPinotQuery { + private LeafStageToPinotQuery() { + } + + /** + * Converts a leaf stage root to a {@link PinotQuery}. + * + * @param tableName the name of the table. Needs to be provided separately since it needs TableCache. + * @param leafStageRoot the root of the leaf stage + * @param skipFilter whether to skip the filter in the query + * @return a {@link PinotQuery} representing the leaf stage + */ + public static PinotQuery createPinotQuery(String tableName, RelNode leafStageRoot, boolean skipFilter) { Review Comment: We are not including sort and aggregate here which is misleading. I'll add a note in the javadocs and rename the method accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
