ankitsultana commented on code in PR #15959:
URL: https://github.com/apache/pinot/pull/15959#discussion_r2124395131


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/v2/opt/rules/LeafStageWorkerAssignmentRule.java:
##########
@@ -400,6 +413,70 @@ static List<String> sampleSegmentsForLogging(List<String> 
segments) {
     return segments;
   }
 
+  @VisibleForTesting
+  static PinotQuery createPinotQuery(String tableName, TableScan tableScan, 
Deque<PRelNode> parents,

Review Comment:
   note for reviewers: This logic to create a `PinotQuery` out of a leaf stage 
is similar to `ServerPlanRequestVisitor` which is run in the servers. However, 
that visitor deals with `PlanNode` types, whereas here we deal with `PRelNode`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to