ankitsultana commented on code in PR #15959:
URL: https://github.com/apache/pinot/pull/15959#discussion_r2125031108
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -634,6 +634,11 @@ public static class QueryOptionKey {
// name, when that segment has multiple partitions in its
columnPartitionMap.
public static final String INFER_INVALID_SEGMENT_PARTITION =
"inferInvalidSegmentPartition";
public static final String USE_LITE_MODE = "useLiteMode";
+ // Used by the MSE Engine to determine whether to use the broker
pruning logic. Only supported by the
+ // new MSE query optimizer.
+ // TODO(mse-physical): Consider removing this query option and making
this the default, since there's already
+ // a table config to enable broker pruning (it is disabled by
default).
Review Comment:
I meant the `routing. segmentPrunerTypes` key in the table config. Based on
my tests we don't prune segments unless this is set (maybe I am missing
something)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
