vrajat commented on code in PR #15773:
URL: https://github.com/apache/pinot/pull/15773#discussion_r2099443742
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/InstanceDataManager.java:
##########
@@ -201,4 +201,10 @@ void reloadSegments(String tableNameWithType, List<String>
segmentNames, boolean
* Returns the instance data directory
*/
String getInstanceDataDir();
+
+ /**
+ * Returns the logical table config and schema for the given logical table
name.
+ */
+ @Nullable
Review Comment:
I've added a TODO.
re: exception, an exception is thrown using `Preconditions`.
```
LogicalTableContext logicalTableContext =
instanceDataManager.getLogicalTableContext(logicalTableName);
Preconditions.checkNotNull(logicalTableContext,
"LogicalTableManager not found for logical table name: " +
logicalTableName);
```
This is similar to all the other gets from `InstanceDataManager`. Is this
pattern OK or should I throw a `TableNotFoundException` or similar ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
