vrajat commented on code in PR #15773: URL: https://github.com/apache/pinot/pull/15773#discussion_r2099448496
########## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/DispatchablePlanMetadata.java: ########## @@ -80,6 +81,24 @@ public class DispatchablePlanMetadata implements Serializable { // Map from workerId -> {planFragmentId -> mailboxes} private final Map<Integer, Map<Integer, MailboxInfos>> _workerIdToMailboxesMap = new HashMap<>(); + /** + * Map from workerId -> {tableType -> {tableName -> segments}} is required for logical tables. + * Raw definition of the map is: + * Map<String, Map<String, Map<String, List<String>>>>. Since this definition is hard to understand - specifically + * what do each of the string keys store, we define two classes: + * {@link TableTypeToSegmentsMap} and {@link TableTypeTableNameToSegmentsMap} to help read code more easily. + */ + public static class TableTypeToSegmentsMap { Review Comment: I wish Java had a typedef like language construct. I can change it now since the code works. FYI: this data structure caused the most amount of delay in making this feature work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org