vrajat commented on code in PR #15773:
URL: https://github.com/apache/pinot/pull/15773#discussion_r2097555632
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/table/LogicalTableRouteInfo.java:
##########
@@ -234,15 +238,15 @@ public boolean hasRealtime() {
@Nullable
@Override
public String getOfflineTableName() {
- return hasOffline() && _logicalTable != null ?
TableNameBuilder.OFFLINE.tableNameWithType(
- _logicalTable.getTableName()) : null;
+ return hasOffline() && _logicalTableName != null ?
TableNameBuilder.OFFLINE.tableNameWithType(_logicalTableName)
Review Comment:
This can happen if a table name that does not exist is provided. I have kept
the same semantics as `ImplicitHybridTableRouteInfo` where the table config is
checked for null to see if it exists. The route provider returns a
TableRouteInfo always instead of a null or an exception. A `TableRouteInfo` is
returned to keep the logic same in `BaseSingleStageRequestHandler`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
