abhishekbafna commented on code in PR #15773:
URL: https://github.com/apache/pinot/pull/15773#discussion_r2097326454
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/routing/table/LogicalTableRouteInfo.java:
##########
@@ -234,15 +238,15 @@ public boolean hasRealtime() {
@Nullable
@Override
public String getOfflineTableName() {
- return hasOffline() && _logicalTable != null ?
TableNameBuilder.OFFLINE.tableNameWithType(
- _logicalTable.getTableName()) : null;
+ return hasOffline() && _logicalTableName != null ?
TableNameBuilder.OFFLINE.tableNameWithType(_logicalTableName)
Review Comment:
How can `_logicalTableName` be null?
should it be set during the init or constructor? Its too basic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
