wirybeaver commented on code in PR #15203:
URL: https://github.com/apache/pinot/pull/15203#discussion_r2083429421


##########
pinot-broker/src/main/java/org/apache/pinot/broker/routing/instanceselector/BaseInstanceSelector.java:
##########
@@ -458,6 +471,19 @@ public Set<String> getServingInstances() {
     return _segmentStates.getServingInstances();
   }
 
+  @VisibleForTesting
+  int getGroup(String instanceID) {
+    int group = DEFAULT_SERVER_REPLICA_GROUP_OF_BROKER_VIEW;
+    ServerInstance server = _enabledServerStore.get(instanceID);
+    if (server == null) {
+      LOGGER.warn("Failed to find server {} in the enabledServerManager when 
update segmentsMap for table {}",

Review Comment:
   Theoretically, the enabledServer and the segment IS | EV is not updated as a 
TXN.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to