tarun11Mavani commented on PR #15756: URL: https://github.com/apache/pinot/pull/15756#issuecomment-2867111360
> @tarun11Mavani : can you also consider adding some sort of E2E tests that test the `numEntriesScannedInFilter` and some other stats? Ideally if any filter code change impacts stats like entries scanned, then the tests should be able to catch it. > > We could also think about adding them to one of the existing tests like `OfflineClusterIntegrationTest`. cc: @Jackie-Jiang : if you have an opinion about this. I see that we have quite a lot of Integration Tests right now so I feel it's best to reuse one of them. This will be slightly bigger effort so will take this up in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
