matvj250 commented on code in PR #15684:
URL: https://github.com/apache/pinot/pull/15684#discussion_r2070662087
##########
pinot-spi/pom.xml:
##########
@@ -124,6 +124,72 @@
<reuseForks>true</reuseForks>
</configuration>
</plugin>
+ <plugin>
+ <groupId>com.github.siom79.japicmp</groupId>
+ <artifactId>japicmp-maven-plugin</artifactId>
+ <version>0.23.1</version>
+ <configuration>
+ <oldVersion>
+ <file>
+ <path>${basedir}/resources/pinot-spi-japicmp-baseline.jar</path>
+ </file>
+ </oldVersion>
+<!-- If oldVersion were left blank, 1.3.0 would be the baseline version for
japicmp's comparing. However, we already
+introduced back-incompatible changes since the release of 1.4.0-SNAPSHOT, so
we are using a baseline .jar of the repo here
+(with version as of PR #15684).
+TODO: At the time of the next Pinot release (1.4.0), update the baseline
version here to 1.4.0 and remove
pinot-spi/resources/pinot-spi-japicmp-baseline.jar from repo.-->
+ <newVersion>
+ <file>
+
<path>${project.build.directory}/${project.artifactId}-${project.version}.jar</path>
+ </file>
+ </newVersion>
+ <parameter>
+
<includes>org.apache.pinot.spi.utils.builder.ControllerRequestURLBuilder</includes>
Review Comment:
Made the change
##########
pinot-spi/pom.xml:
##########
@@ -124,6 +124,72 @@
<reuseForks>true</reuseForks>
</configuration>
</plugin>
+ <plugin>
+ <groupId>com.github.siom79.japicmp</groupId>
+ <artifactId>japicmp-maven-plugin</artifactId>
+ <version>0.23.1</version>
+ <configuration>
+ <oldVersion>
+ <file>
+ <path>${basedir}/resources/pinot-spi-japicmp-baseline.jar</path>
+ </file>
+ </oldVersion>
+<!-- If oldVersion were left blank, 1.3.0 would be the baseline version for
japicmp's comparing. However, we already
+introduced back-incompatible changes since the release of 1.4.0-SNAPSHOT, so
we are using a baseline .jar of the repo here
+(with version as of PR #15684).
+TODO: At the time of the next Pinot release (1.4.0), update the baseline
version here to 1.4.0 and remove
pinot-spi/resources/pinot-spi-japicmp-baseline.jar from repo.-->
+ <newVersion>
+ <file>
+
<path>${project.build.directory}/${project.artifactId}-${project.version}.jar</path>
+ </file>
+ </newVersion>
+ <parameter>
+
<includes>org.apache.pinot.spi.utils.builder.ControllerRequestURLBuilder</includes>
Review Comment:
Yes, this is left over from testing. It should be "org.apache.pinot.spi",
meaning the japicmp checks will occur for all the classes, etc. in pinot-spi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
