UOETianleZhang commented on PR #15684: URL: https://github.com/apache/pinot/pull/15684#issuecomment-2845265938
> For the jar file to compare, can we download it as part of the CI or use the previous release version? Hi @xiangfu0, could you elaborate a little bit more on the idea of downloading as CI? > or use the previous release version? This is also what @matvj250 and I wanted to achieve. In theory, japicmp should compare the current commit with the last stable version (1.3.0 in this case) to make sure no back-incompatible interface changes. However, currently it is not possible to use 1.3.0 as the base version because there are already back-incompatible changes. This is why we have the jar of the current commit as the baseline (temporarily). After 1.4.0 is released, we can delete the jar and update the base version to 1.4.0 in the plugin config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
