matvj250 opened a new pull request, #15684: URL: https://github.com/apache/pinot/pull/15684
Implementing japicmp in the pinot-spi module to fail builds (i.e. running mvn clean) when incompatible SPI changes are made, such as removing methods, changing method return types, etc. Compatible SPI changes, such as adding new methods, will not fail builds. I have tested that this works as intended. Some additional information about the package: - japicmp works by comparing two versions (.jar files) of a repository. I am pushing a .jar representing apache/pinot in its current state, which will be compared against whatever SPI changes a user makes. - japicmp will generate a .diff and .md file with in-depth information on changes made, and whether they are compatible or not. - The compatibility of a few of the checks japicmp performs were changed; for example, annotation deletions will be treated as incompatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
