UOETianleZhang commented on code in PR #15684:
URL: https://github.com/apache/pinot/pull/15684#discussion_r2069552185
##########
pinot-spi/pom.xml:
##########
@@ -124,6 +124,68 @@
<reuseForks>true</reuseForks>
</configuration>
</plugin>
+ <plugin>
+ <groupId>com.github.siom79.japicmp</groupId>
+ <artifactId>japicmp-maven-plugin</artifactId>
+ <version>0.23.1</version>
+ <configuration>
+ <oldVersion>
+ <file>
+ <path>${basedir}/resources/pinot-spi-japicmp-baseline.jar</path>
Review Comment:
Could you add a comment here similar to below:
```
Given we already introduced back-incompatible changes since the start of
1.4.0-SNAPSHOT, a base-line jar is introduced here (with version of PR #15684)
instead of directly making 1.3.0 as the baseline version.
TODO: At the time of the next Pinot release (1.4.0), update the base line
version to 1.4.0 and remove pinot-spi/resources/pinot-spi-japicmp-baseline.jar.
```
##########
pinot-spi/pom.xml:
##########
@@ -124,6 +124,68 @@
<reuseForks>true</reuseForks>
</configuration>
</plugin>
+ <plugin>
+ <groupId>com.github.siom79.japicmp</groupId>
+ <artifactId>japicmp-maven-plugin</artifactId>
+ <version>0.23.1</version>
+ <configuration>
+ <oldVersion>
+ <file>
+ <path>${basedir}/resources/pinot-spi-japicmp-baseline.jar</path>
+ </file>
+ </oldVersion>
+ <newVersion>
+ <file>
+
<path>${project.build.directory}/${project.artifactId}-${project.version}.jar</path>
+ </file>
+ </newVersion>
+ <parameter>
+
<includes>org.apache.pinot.spi.utils.builder.ControllerRequestURLBuilder</includes>
+ <onlyModified>true</onlyModified>
+ <skipXmlReport>true</skipXmlReport>
+ <skipHtmlReport>true</skipHtmlReport>
+
<breakBuildOnSourceIncompatibleModifications>true</breakBuildOnSourceIncompatibleModifications>
+ <overrideCompatibilityChangeParameters>
+ <overrideCompatibilityChangeParameter>
+ <compatibilityChange>ANNOTATION_MODIFIED</compatibilityChange>
+ <sourceCompatible>false</sourceCompatible>
Review Comment:
Does `<sourceCompatible>false</sourceCompatible>` mean ANNOTATION_MODIFIED
will fail the build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
