yashmayya commented on code in PR #15180:
URL: https://github.com/apache/pinot/pull/15180#discussion_r1991577402
##########
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/BinaryWorkloadScheduler.java:
##########
@@ -94,7 +96,8 @@ public ListenableFuture<byte[]> submit(ServerQueryRequest
queryRequest) {
queryRequest.getTimerContext().startNewPhaseTimer(ServerQueryPhase.SCHEDULER_WAIT);
if
(!QueryOptionsUtils.isSecondaryWorkload(queryRequest.getQueryContext().getQueryOptions()))
{
QueryExecutorService queryExecutorService =
_resourceManager.getExecutorService(queryRequest, null);
- ListenableFutureTask<byte[]> queryTask =
createQueryFutureTask(queryRequest, queryExecutorService);
+ ExecutorService innerExecutorService =
QueryThreadContext.contextAwareExecutorService(queryExecutorService);
+ ListenableFutureTask<byte[]> queryTask =
createQueryFutureTask(queryRequest, innerExecutorService);
Review Comment:
Could we add the context aware wrapper directly in the resource manager
instead of wrapping it at all the call sites? Or is there a particular reason
you chose to do it this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
