vrajat commented on code in PR #15180:
URL: https://github.com/apache/pinot/pull/15180#discussion_r1987400267
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##########
@@ -407,11 +408,12 @@ public String cancelQuery(
}
return resp;
} else if (_requestHandler.cancelQuery(Long.parseLong(id), timeoutMs,
_executor, _httpConnMgr, serverResponses)) {
- String resp = "Cancelled query: " + id;
- if (verbose) {
- resp += " with responses from servers: " + serverResponses;
- }
- return resp;
+ QueryThreadContext.setIds(Long.parseLong(id), id);
Review Comment:
Should the Ids be set at the beginning of the try block ? Both
`cancelQueryByClientId` and `cancelQuery` call `queryDispatcher` etc Should the
Ids be set at the beginning of the try block ? Both `cancelQueryByClientId` and
`cancelQuery` call `queryDispatcher` etc
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/server/QueryServer.java:
##########
@@ -125,9 +132,9 @@ public void shutdown() {
@Override
public void submit(Worker.QueryRequest request,
StreamObserver<Worker.QueryResponse> responseObserver) {
- Map<String, String> requestMetadata;
+ Map<String, String> reqMetadata;
Review Comment:
Why was the name of variable changed ?
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -175,14 +175,15 @@ public void init(PinotConfiguration config,
InstanceDataManager instanceDataMana
String joinOverflowModeStr =
config.getProperty(CommonConstants.MultiStageQueryRunner.KEY_OF_JOIN_OVERFLOW_MODE);
_joinOverflowMode = joinOverflowModeStr != null ?
JoinOverFlowMode.valueOf(joinOverflowModeStr) : null;
- _executorService = ExecutorServiceUtils.create(config,
Server.MULTISTAGE_EXECUTOR_CONFIG_PREFIX,
- "query-runner-on-" + port, Server.DEFAULT_MULTISTAGE_EXECUTOR_TYPE);
-
- int hardLimit = HardLimitExecutor.getMultiStageExecutorHardLimit(config);
Review Comment:
Where was this block of code moved to ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
