vrajat commented on code in PR #15037:
URL: https://github.com/apache/pinot/pull/15037#discussion_r1957774685
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -322,10 +320,7 @@ private InstanceResponseBlock
executeInternal(ServerQueryRequest queryRequest, E
_serverMetrics.addMeteredTableValue(tableNameWithType,
ServerMeter.QUERY_EXECUTION_EXCEPTIONS, 1);
instanceResponse = new InstanceResponseBlock();
// Do not log verbose error for BadQueryRequestException and
QueryCancelledException.
- if (e instanceof BadQueryRequestException) {
- LOGGER.info("Caught BadQueryRequestException while processing
requestId: {}, {}", requestId, e.getMessage());
-
instanceResponse.addException(QueryException.getException(QueryException.QUERY_VALIDATION_ERROR,
e));
- } else if (e instanceof QueryCancelledException) {
+ if (e instanceof QueryCancelledException) {
Review Comment:
I asked in slack as well and not specific to this PR. Why is this pattern
used instead `catch(QueryCancelledException) { ... } catch (Exception e) { ... }
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -322,10 +320,7 @@ private InstanceResponseBlock
executeInternal(ServerQueryRequest queryRequest, E
_serverMetrics.addMeteredTableValue(tableNameWithType,
ServerMeter.QUERY_EXECUTION_EXCEPTIONS, 1);
instanceResponse = new InstanceResponseBlock();
// Do not log verbose error for BadQueryRequestException and
QueryCancelledException.
- if (e instanceof BadQueryRequestException) {
- LOGGER.info("Caught BadQueryRequestException while processing
requestId: {}, {}", requestId, e.getMessage());
-
instanceResponse.addException(QueryException.getException(QueryException.QUERY_VALIDATION_ERROR,
e));
- } else if (e instanceof QueryCancelledException) {
+ if (e instanceof QueryCancelledException) {
Review Comment:
I asked in slack as well and not specific to this PR. Why is this pattern
used instead `catch(QueryCancelledException) { ... } catch (Exception e) { ...
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
