jackjlli commented on a change in pull request #4047: Create
leadControllerResource in helix cluster
URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r275972992
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/config/TagNameUtils.java
##########
@@ -55,6 +56,11 @@ public static TenantRole getTenantRoleFromTag(String
tagName) throws InvalidConf
if (tagName.endsWith(TenantRole.BROKER.toString())) {
return TenantRole.BROKER;
}
+ // Helix uses this tag to support full-auto.
+ // Return null if the tag is controller, which isn't a type of tenant in
Pinot.
+ if
(tagName.equalsIgnoreCase(CommonConstants.Helix.CONTROLLER_INSTANCE_TYPE)) {
+ return null;
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
