jackjlli commented on a change in pull request #4047: Create
leadControllerResource in helix cluster
URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r289980088
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -37,8 +37,15 @@
public static final String SERVER_INSTANCE_TYPE = "server";
public static final String BROKER_INSTANCE_TYPE = "broker";
+ public static final String CONTROLLER_INSTANCE_TYPE = "controller";
public static final String BROKER_RESOURCE_INSTANCE = "brokerResource";
+ public static final String LEAD_CONTROLLER_RESOURCE_NAME =
"leadControllerResource";
+
+ // More information on why these numbers are set can be found in the
following doc:
+ //
https://cwiki.apache.org/confluence/display/PINOT/Controller+Separation+between+Helix+and+Pinot
+ public static final int
DEFAULT_NUMBER_OF_PARTITIONS_IN_LEAD_CONTROLLER_RESOURCE = 17;
+ public static final int DEFAULT_NUMBER_OF_CONTROLLER_REPLICAS = 1;
Review comment:
The reason is in the ciwiki link above. There's no huge difference between 1
or more, except there'll be SLAVEs shown in the resource if the number is > 1.
For Pinot, it takes minimum efforts to transit from OFFLINE to SLAVE and from
SLAVE to MASTER. Thus, we don't need SLAVE to be shown in the resource.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
