jackjlli commented on a change in pull request #4047: Create 
leadControllerResource in helix cluster
URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r273321860
 
 

 ##########
 File path: 
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java
 ##########
 @@ -110,6 +113,8 @@ public static void createHelixClusterIfNeeded(String 
helixClusterName, String zk
           zkClient.close();
         }
       }
+      createLeadControllerResourceIfNeeded(helixClusterName, admin, 
enableBatchMessageMode,
 
 Review comment:
   I created a new method called `setupHelixCluster()` which will call 
`createHelixClusterIfNeeded` and `createLeadControllerResourceIfNeeded` 
sequentially.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to