jackjlli commented on a change in pull request #4047: Create
leadControllerResource in helix cluster
URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r273318587
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java
##########
@@ -154,6 +159,8 @@ public static void createHelixClusterIfNeeded(String
helixClusterName, String zk
.buildEmptyIdealStateForBrokerResource(admin, helixClusterName,
enableBatchMessageMode);
admin.setResourceIdealState(helixClusterName,
CommonConstants.Helix.BROKER_RESOURCE_INSTANCE, idealState);
initPropertyStorePath(helixClusterName, zkPath);
+
+ createLeadControllerResourceIfNeeded(helixClusterName, admin,
enableBatchMessageMode, leadControllerResourceConfig);
Review comment:
The reason why I put it inside `createHelixClusterIfNeeded` is that
`createHelixClusterIfNeeded` method can only focus on setting up cluster steps,
whereas `startHelixControllerInStandadloneMode` method can only focus on
initializing controller.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
