danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049211910
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkTables.java:
##########
@@ -78,6 +82,11 @@ public static HoodieFlinkTable<?> createTable(
*/
public static HoodieFlinkTable<?> createTable(Configuration conf) {
HoodieWriteConfig writeConfig =
FlinkWriteClients.getHoodieClientConfig(conf, true, false);
- return createTableInternal(writeConfig, HoodieFlinkEngineContext.DEFAULT);
+ return createTableInternal(writeConfig, HoodieFlinkEngineContext.DEFAULT,
Option.empty());
+ }
+
+ public static HoodieFlinkTable<?> createTable(Configuration conf,
TransactionManager txnManager) {
+ HoodieWriteConfig writeConfig =
FlinkWriteClients.getHoodieClientConfig(conf, true, false);
Review Comment:
not a blocker as the caller has explicit validation of the txn manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
