danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049203628
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkTables.java:
##########
@@ -53,7 +56,8 @@ public static HoodieFlinkTable<?> createTable(Configuration
conf, RuntimeContext
HadoopFSUtils.getStorageConf(getHadoopConf(conf)),
new FlinkTaskContextSupplier(runtimeContext));
HoodieWriteConfig writeConfig =
FlinkWriteClients.getHoodieClientConfig(conf, true);
Review Comment:
The caller always have a check for the presense of the txn manager now,
should be safe to evolve, there are indeed cases that do not use the txn
manager, I'm inclined we keep it as it is now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
