FrankChen021 commented on code in PR #20562:
URL: https://github.com/apache/druid/pull/20562#discussion_r4266638392


##########
processing/src/main/java/org/apache/druid/query/QueryContexts.java:
##########
@@ -132,6 +132,13 @@ public class QueryContexts
   public static final String FORCE_PROJECTION = "forceProjections";
   public static final String USE_PROJECTION = "useProjection";
 
+  /**
+   * Overrides the {@link org.apache.druid.segment.loading.AcquireMode} an 
engine uses to acquire segments from the
+   * segment cache; see {@link QueryContext#getSegmentAcquireMode}. Intended 
for testing, debugging, and performance
+   * comparison.
+   */
+  public static final String SEGMENT_ACQUIRE_MODE = "segmentAcquireMode";

Review Comment:
   `.visibility(Visibility.INTERNAL)`
   
   Noted, this visibility property is designed for thoes internal used 
properties, they will not be reflected in the doc.
   
   And for INTERNAL parameters, `description` is not also needed. my above 
example might be a little bit confusion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to